Skip to content

#1814 Fix path parameter extraction for complex Google API endpoints #1815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

#1814 Fix path parameter extraction for complex Google API endpoints #1815

wants to merge 2 commits into from
+611 −1

Conversation

goldylocks87
Copy link

@goldylocks87 goldylocks87 commented Jul 7, 2025 •
edited
Loading

Fixes #1814

  • Fix GoogleApiToOpenApiConverter to handle path parameters in complex endpoints like /v1/documents/{documentId}:batchUpdate
  • Use Google Discovery Document 'location' field
  • Add comprehensive test suite for Google Docs batchUpdate functionality
  • Verify parameter location handling for complex endpoint patterns
  • Test schema validation for BatchUpdateDocumentRequest/Response

@google-cla Google CLA
Copy link

google-cla bot commented Jul 7, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@goldylocks87 goldylocks87 force-pushed the fix-issue-1814-path-parameter-extraction branch 2 times, most recently from ba1887f to a9946d7 Compare July 7, 2025 07:55
@goldylocks87
fix: resolve path parameter extraction for complex Google API endpoints
501359c 
Fixes google#1814

- Fix GoogleApiToOpenApiConverter to properly handle path parameters in
  complex endpoints like /v1/documents/{documentId}:batchUpdate
- Trust Google Discovery Document 'location' field over URL parsing
- Add comprehensive test suite for Google Docs batchUpdate functionality
- Verify parameter location handling for complex endpoint patterns
- Test schema validation for BatchUpdateDocumentRequest/Response
@goldylocks87 goldylocks87 force-pushed the fix-issue-1814-path-parameter-extraction branch from a9946d7 to 501359c Compare July 7, 2025 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue: Path Parameter Extraction for Complex Google API Endpoints
1 participant
@goldylocks87